This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Fix issue #166: Badges' style in Privacy Status block at Dashboard is…#167
Open
davidnguyen-joomlashine wants to merge 1 commit intojoomla-projects:masterfrom
Open
Fix issue #166: Badges' style in Privacy Status block at Dashboard is…#167davidnguyen-joomlashine wants to merge 1 commit intojoomla-projects:masterfrom
davidnguyen-joomlashine wants to merge 1 commit intojoomla-projects:masterfrom
Conversation
…at Dashboard is not consistent
Contributor
|
Please add a screenshot. That helps to visualize. |
Author
Contributor
|
|
|
The background made the status unreadable. |
Author
|
@simbus82 what do you think of this style |
|
I don't think this ensure the compliance with AA WCAG 2.1, it's needed more contrast for the text vs background. |
Author
|
Checked this style with WCAG Standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #166 .
Summary of Changes
Change CSS class "text-" to "badge badge- " in administrator/modules/mod_privacy_dashboard/tmpl/default.php
Testing Instructions
Expected result
Actual result
Documentation Changes Required