This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Fix issue #121: Logged in users#171
Open
davidnguyen-joomlashine wants to merge 2 commits intojoomla-projects:masterfrom
Open
Fix issue #121: Logged in users#171davidnguyen-joomlashine wants to merge 2 commits intojoomla-projects:masterfrom
davidnguyen-joomlashine wants to merge 2 commits intojoomla-projects:masterfrom
Conversation
Contributor
|
a better option would be to simply revert all the unnecessary changes that were made in this module and not introduce accessibility issues |
Author
|
@brianteeman I'm not sure because HTML structure is total different from origin. Do you have another idea? |
Contributor
|
and that is the mistake. This template can not be an alternative template if it requires changes to the core markup. I keep saying this but none of you listen and you keep treating this as if it will be the only template and you can change everything. |
Author
|
@brianteeman yes, I agreed with your idea. I will create an override for this module |
…t core file and create an mod_logged override
Author
|
Reverted all change at core file and created an mod_logged override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #121 .
Summary of Changes
Made some changes in administrator/modules/mod_logged/tmpl/default.php
Testing Instructions
Expected result
Actual result
Documentation Changes Required