Reset calculate button on early validation and add UI tests#25
Merged
Reset calculate button on early validation and add UI tests#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
finalizeCalculationhelper injs/ui.jsthat restores the calculate button text and state, and call it from early validation branches and thefinallyblock to guarantee reset on all exit paths.tests/unit/ui.test.jswith three new tests that assert rejection of future birthdates and that calculator functions are not called, simulate missing expectancy data to verify error handling, and validate that view switching updatesaria-labelledbyand calls the correct renderer.js/ui.jsandtests/unit/ui.test.jsto implement the fix and the additional tests.Testing
npm test -- --runand iterated until green; the final run reported all tests passing (47 passed).tests/unit/ui.test.js(updated),tests/unit/calculator.test.js, and multiplegridRendererunit tests which all executed successfully during the run.calculatebutton state no longer remains"Calculating..."after early validation exits.Codex Task