use pointCommand in findDefString to allow static-ls to jump to bindings

[goolord]

Instead of querying the DB directly, we could use pointCommand to get the location of a name, which means static-ls could jump to the definition of foo in the trivial example

do
  foo <- getFoo
  launchMissles foo

[josephsumabat]

Is the local definition not working for you? We already look up the hiefile in the snippet above

      identifiers <- runMaybeT $ do
        hieLineCol <- lineColToHieLineCol path lineCol
        hiePos <- hieLineColToPos path hieLineCol
        valid <- lift $ isHiePosValid path pos hiePos
        Monad.guard valid
        hieView <- getHieView path
        let identifiers = HieView.Query.fileIdentifiersAtRangeList (Just (LineColRange.point hieLineCol)) hieView
        pure identifiers

(This does effectively the same thing as pointCommand)

findDefString is only intended as a fallback mechanism when we don't have an hie file

(Let me know if I'm missing anything else here)

[goolord]

yes, goto definition isn't working for local bindings on master. I guess I missed fileIdentifiersAtRangeList since I was mostly grepping around for hiedb functions to debug this. not sure why that wouldn't work, but I can tell you using pointCommand is working for certain

[josephsumabat]

I'm going to take some time to look into this before making a decision on merging or closing. we probably still want some fallback if hie files are not available

[Mycatty]

Thanks