Update regex pattern in shouldDropLine#184
Update regex pattern in shouldDropLine#184walseb wants to merge 2 commits intojosephsumabat:mainfrom
Conversation
|
I have tried this change out briefly, but now I sometimes get errors with this: What's abnormal is this: Which isn't even shown in the GHCIWatch output for some reason. I will try adjusting the regexp by adding a check for whether BOL is to the left of the bar. |
|
That didn't fix it. Is It seems to be appearing in the beginning of all errors now. |
|
I've wanted to fix the parsing for a bit (we actually have a different set up on our internal fork..) but if you can get this tested working I'll happily merge. |
|
I have been testing this over the last few days with no issues. I suppose the BOL check in the regexp might be unnecessary. I have never seen the error line preview bars appear at the beginning of a line: But it might be possible, and I don't see a reason to remove it as it doesn't conflict with anything that I know of (especially as the last solution would capture ANY bars used in the line at all). |
|
I forgot to mention:
Regarding that, |
Ref: #183
I haven't had time to try this change yet. Perhaps there are issues with it.