Open
Conversation
Contributor
nbd168
commented
Feb 7, 2026
nbd168
commented
- avoid double close of externally owned channel fds
- fix refcounting bug
In uc_ubus_channel_req_cb an extra ref is taken for args and method, which are not used elsewhere. Signed-off-by: Felix Fietkau <nbd@nbd.name>
When a channel is opened via an fd obtained through fileno(), the fd is owned by an external resource. Track this in fd_handle and detach from uloop without closing the fd on disconnect/shutdown. Signed-off-by: Felix Fietkau <nbd@nbd.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.