The gap option does not work unless the arrowShow option is set to true.#71
Open
joefearnley wants to merge 3 commits intojpillora:masterfrom
joefearnley:master
Open
The gap option does not work unless the arrowShow option is set to true.#71joefearnley wants to merge 3 commits intojpillora:masterfrom joefearnley:master
joefearnley wants to merge 3 commits intojpillora:masterfrom
joefearnley:master
Conversation
|
Hi, @joefearnley This repo seems to be abandonned with no activity since later 2015. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap option does not work if the arrowShow option set to true in the setElementPosition function. When it is, the gap is calculated using the arrowSize variable, which is not initialized at this point in the function. This change initializes that variable so it works with and without the arrow.