Add support for systems with /boot outside the @-subvolume#6
Open
zapp-brannigan wants to merge 3 commits intojrabinow:mainfrom
Open
Add support for systems with /boot outside the @-subvolume#6zapp-brannigan wants to merge 3 commits intojrabinow:mainfrom
zapp-brannigan wants to merge 3 commits intojrabinow:mainfrom
Conversation
|
I have patched this PR in my Arch PKGbuild and it seems to work fine. But not with the current pacman hook suggested in the wiki. There used to be a single hook listed, now it is for pre- and post- |
|
This works well, but one problem I see is that it relies on the conf. only for restoring /boot. If external_boot is true, and there is no backup in the snapshot, /boot will be removed and not replaced because of the missing backup in the snapshot. Maybe there should be a test so this does not happen? Just removing the rm -rf and replacing cp with rsync -aq --delete should do the trick and not wipe out the current /boot if there is nothing to cp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this nice tool.
If you have an encrypted system your
/bootis usually not part of the root-partition.I`ve made a small patch which resets the boot-partition alongside with the @-subvolume.
It aussumes that you use the pacman-hook suggested in https://wiki.archlinux.org/title/System_backup#Snapshots_and_/boot_partition