feat: Simplify docker startup using docker compose#7
Open
AdamZh0u wants to merge 1 commit intojreades:masterfrom
Open
feat: Simplify docker startup using docker compose#7AdamZh0u wants to merge 1 commit intojreades:masterfrom
AdamZh0u wants to merge 1 commit intojreades:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request aims to simplify docker startup configuration commands using docker compose, addressing potential input errors and line break issues for users who are unfamiliar with command line operations.
Issue
I've noticed many users encounter problems when using the command:
Issues arise due to unfamiliarity with command line or input method problems, including:
Implementation
I use docker compose here to simplify the docker startup configuration commands:
docker compose up -dto start the environmentDOCKER_IMAGE=jreades/sds:2024-silicon docker compose up -dto start the environmentTesting
I have tested on both Windows and macOS M chip platforms.
Potential Problems
The choice between silicon image and intel image depends on architecture detection. I tried to directly pull sds:2024 without indicating platform but encountered issues. I also attempted to specify
platformin docker compose, but this would require introducing .env configuration, which might increase complexity. Currently, I haven't found a unified startup command for different platforms.