Skip to content

feat: Simplify docker startup using docker compose#7

Open
AdamZh0u wants to merge 1 commit intojreades:masterfrom
AdamZh0u:dev
Open

feat: Simplify docker startup using docker compose#7
AdamZh0u wants to merge 1 commit intojreades:masterfrom
AdamZh0u:dev

Conversation

@AdamZh0u
Copy link

@AdamZh0u AdamZh0u commented Dec 2, 2024

Summary

This pull request aims to simplify docker startup configuration commands using docker compose, addressing potential input errors and line break issues for users who are unfamiliar with command line operations.

Issue

I've noticed many users encounter problems when using the command:

docker run --rm -d --name sds2024 -p 8888:8888 \
   -v "$(pwd):/home/jovyan/work" \
  jreades/sds:2024-intel start.sh jupyter lab \
  --LabApp.password='' --ServerApp.password='' --NotebookApp.token=''

Issues arise due to unfamiliarity with command line or input method problems, including:

  • Single/double quote or Chinese quote issues
  • Missing spaces causing JupyterLab to require passwords
  • Line break issues across different platforms
  • Misspelling "jovyan" as "joyvan" in the volume mount path, resulting in an empty work directory in Jupyter

Implementation

I use docker compose here to simplify the docker startup configuration commands:

  • For Intel platforms: Download this docker-compose.yml file and run docker compose up -d to start the environment
  • For M chips: Download this docker-compose.yml file and run DOCKER_IMAGE=jreades/sds:2024-silicon docker compose up -d to start the environment

Testing

I have tested on both Windows and macOS M chip platforms.

Potential Problems

The choice between silicon image and intel image depends on architecture detection. I tried to directly pull sds:2024 without indicating platform but encountered issues. I also attempted to specify platform in docker compose, but this would require introducing .env configuration, which might increase complexity. Currently, I haven't found a unified startup command for different platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant