Open
Conversation
Owner
|
Interesting. I think it's probably better to come up with an extension mechanism around eproject-maybe-turn on, and then put the magit stuff in a separate file that uses that extension mechanism. Then we don't require magit (or confuse the byte compiler with warnings about the magit symbols not existing), and users can easily control the features. And other extensions will be able to do something similar without modifying eproject.el directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation credit goes to @binarin, but I'm requesting a merge because I find it useful. Admittedly, special-casing magit-status-mode buffers smells a little wrong, but the same thing is done with dired buffers. Ideally, there'd be some macro that provides a generic way to add special case buffers to the tests in
eproject--buffer-file-name, but I haven't spent any time on it because this works for me.