Open
Conversation
|
+1 for this. I need this for one of my projects. |
|
+1 |
|
I'm kind of surprised this is still hanging out here. This PR works exactly as I would have imagined it would work by default (the same as yuidoc CLI). If the hack nature of this fix is the concern, perhaps it would be ok to simply give it an option flag in the gulp plugin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request meant to add to the discussion on #4
This is a pretty ugly hack
The only way I was able to get gulp-yuidoc to write docs with relative path names is to set the base on my files in this plugin. Doing it via
gulp.srcwould cause weird behavior where I would have to checkvinyl.baseinlib/parser.jsand passvinyl.pathorvinyl.relativeand that felt like an even bigger hack.This solution just sets the file base to
vinyl.cwdand then passes the relative path into thefilemapanddirmap.Concerns: I'm very concerned that doing this will result in problems if people try to chain other commands in their pipes.