Skip to content

Conversation

@weiliddat
Copy link
Contributor

  • uploaded 2025 photos
  • copied the 2024 archive page for 2025 placeholder
  • fixed the 2024 archive page link
  • images with vertical aspect ratio were leaking out of the parent button bounding box; in a mobile view they were also not expanding to fill the available space on a single column

@netlify
Copy link

netlify bot commented Jun 28, 2025

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit 49f93be
🔍 Latest deploy log https://app.netlify.com/projects/jscraftcamp/deploys/6862861db502150008cd4ce7
😎 Deploy Preview https://deploy-preview-2277--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

images with vertical aspect ratio were leaking out of the parent button bounding box; in a mobile view they were also not expanding to fill the available space on a single column
@cowglow cowglow enabled auto-merge (squash) June 30, 2025 06:07
@cowglow cowglow disabled auto-merge June 30, 2025 06:07
@cowglow cowglow self-requested a review June 30, 2025 06:07
Copy link
Member

@cowglow cowglow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for sharing. @Narigo @wolframkriesing can we go ahead and merge?

@weiliddat
Copy link
Contributor Author

@cowglow sorry only just added the photo credit + explicit licence and noticed that you've approved it. Hope it's OK?

@Narigo
Copy link
Member

Narigo commented Jun 30, 2025

Hey, I've only looked at it from the outside and see credits on every photo page, like this here from 2018 as well: https://deploy-preview-2277--jscraftcamp.netlify.app/events/2018/photos

If you want, I can fix that, I'd put the credit information in an optional slot, so we're able to add whatever we like.

Other than that it looks really nice, thank you for that! I should probably add some kind of image minification / thumb nailing script to run for us 😅

@weiliddat
Copy link
Contributor Author

Oh yeah whoops I added it to the Layout — I can add the optional slot too, gimme a few mins

@weiliddat
Copy link
Contributor Author

@cowglow cowglow merged commit 12ee6e3 into jscraftcamp:main Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants