-
-
Notifications
You must be signed in to change notification settings - Fork 435
feat: 2025 photos #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 2025 photos #2277
Conversation
weiliddat
commented
Jun 28, 2025
- uploaded 2025 photos
- copied the 2024 archive page for 2025 placeholder
- fixed the 2024 archive page link
- images with vertical aspect ratio were leaking out of the parent button bounding box; in a mobile view they were also not expanding to fill the available space on a single column
✅ Deploy Preview for jscraftcamp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
images with vertical aspect ratio were leaking out of the parent button bounding box; in a mobile view they were also not expanding to fill the available space on a single column
6494c27 to
381a2a2
Compare
cowglow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for sharing. @Narigo @wolframkriesing can we go ahead and merge?
|
@cowglow sorry only just added the photo credit + explicit licence and noticed that you've approved it. Hope it's OK? |
|
Hey, I've only looked at it from the outside and see credits on every photo page, like this here from 2018 as well: https://deploy-preview-2277--jscraftcamp.netlify.app/events/2018/photos If you want, I can fix that, I'd put the credit information in an optional slot, so we're able to add whatever we like. Other than that it looks really nice, thank you for that! I should probably add some kind of image minification / thumb nailing script to run for us 😅 |
|
Oh yeah whoops I added it to the Layout — I can add the optional slot too, gimme a few mins |
