Skip to content

Conversation

@Xetoxyc
Copy link
Contributor

@Xetoxyc Xetoxyc commented Jun 30, 2025

maybeV is undefined if tShirtSize is removed

When tShirtSize is removed/undefined, maybeV becomes undefined but still gets processed through the uppercase conversion in the default switch case, causing unexpected behavior.

fixes #2229

@netlify
Copy link

netlify bot commented Jun 30, 2025

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit e2dfe37
🔍 Latest deploy log https://app.netlify.com/projects/jscraftcamp/deploys/68652e0afba4b9000819f5f9
😎 Deploy Preview https://deploy-preview-2278--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 19 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@Narigo Narigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works for all of these cases now:

{
  "tShirtSize": undefined,
  "tShirtSize": null,
  "tShirtSize": "",
  "tShirtSize": false,
  "tShirtSize": 0,
}

and removing "tShirtSize" field altogether!

I like it, thank you!

@Narigo Narigo merged commit 9b52e2f into jscraftcamp:main Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Allow removing T-Shirt size option for participants

3 participants