Extract common functionality into core by adamlogic · Pull Request #6 · judoscale/judoscale-java

adamlogic · 2026-02-02T20:40:18Z

We ended up with a lot of duplicated code when we added judoscale-spring-boot-2-starter. This PR extracts what we can into judoscale-core.

There's still some functionality that feels like it should be in core (like the API clients), but we're constrained that core must remain compatible with Java 8, which means we can't use java.net.http.HttpClient like judoscale-spring-boot-starter can.

Note

Medium Risk
Refactors core metrics reporting/serialization and request queue-time parsing used by both starters, so regressions could impact telemetry accuracy or reporting behavior despite largely equivalent logic.

Overview
Extracts duplicated functionality into judoscale-core by adding ConfigBase, QueueTimeCalculator, ReportBuilder, Reporter, and an Adapter model (with Jackson added as a core dependency).

Updates both judoscale-spring-boot-starter and judoscale-spring-boot-2-starter to extend/use these core utilities: configs now inherit from ConfigBase, filters call QueueTimeCalculator (and warn on unparseable headers), API clients build payloads via ReportBuilder (including per-starter adapter name/version), and Spring reporters become thin wrappers over core Reporter. Adds comprehensive unit tests in core and removes now-redundant JSON-building tests from the Spring Boot starter.

^{Written by Cursor Bugbot for commit 6df6964. This will update automatically on new commits. Configure here.}

carlosantoniodasilva

Nice cleanup, just a few bits of food for thought.

carlosantoniodasilva · 2026-02-03T13:04:09Z

judoscale-spring-boot-2-starter/src/main/java/com/judoscale/spring/JudoscaleConfig.java

-        String configuredUrl = getApiBaseUrl();
-        return configuredUrl != null && !configuredUrl.trim().isEmpty();
-    }
+public class JudoscaleConfig extends ConfigBase {


Do these still need to have their own class rather than using the config one? Seems like it's still necessary due to specific framework things?

yeah, it's the @ConfigurationProperties line above that's specific to Spring Boot.

@ConfigurationProperties is Spring Boot's way of automatically binding external configuration to Java objects. With @ConfigurationProperties(prefix = "judoscale"):

# application.properties judoscale.api-base-url=https://api.judoscale.com/abc123

or environment variables:

JUDOSCALE_URL=https://api.judoscale.com/abc123

...automatically get mapped to the corresponding setters (setApiBaseUrl(), etc.).

Gotcha, thanks for clarifying 👍

carlosantoniodasilva · 2026-02-03T13:11:55Z

judoscale-core/src/main/java/com/judoscale/core/ReportBuilder.java

+        ObjectNode adapters = objectMapper.createObjectNode();
+        ObjectNode springBootAdapter = objectMapper.createObjectNode();
+        springBootAdapter.put("adapter_version", adapterVersion);
+        adapters.set("judoscale-spring-boot", springBootAdapter);


Should this handle multiple adapters somehow? I think our report builder on other packages pass the list of adapters if there are multiple (it's not the case on the java package yet because we can only have one, but it might be in the future)

e.g.: https://github.com/judoscale/judoscale-ruby/blob/aeb67bdff4370665543a8b6b5bd3abb5381dea2f/judoscale-ruby/lib/judoscale/report.rb#L18

Yes definitely and this was an oversight. Core should not have any knowledge about the SpringBootAdapter. Good catch!

carlosantoniodasilva · 2026-02-03T13:13:22Z

judoscale-spring-boot-2-starter/src/main/java/com/judoscale/spring/JudoscaleApiClient.java

-    private static final ObjectMapper objectMapper = new ObjectMapper();
    private static final int MAX_RETRIES = 3;
-    private static final String ADAPTER_VERSION = loadAdapterVersion();
+    private static final String ADAPTER_VERSION = ReportBuilder.loadAdapterVersion(JudoscaleApiClient.class);


We might be able to extract more Api client functionality into core to send these requests, but I think we might need to handle the adapters reporting in the process as well (see my other comment).

The challenge with the API client is that our core library needs to support Java 8 as does the Spring Boot 2 starter, but the Spring Boot starter can use the built-in HTTP client from Java 11. For now I've kept them separate.

I see, makes sense... well I guess in the future we could revisit so that each lib provides the http interface, and core provides the base api client that handles the flow of request & retrying.... anyway, problem for later.

FWIW, this is me playing with Claude 😄: a refactoring extracting a base class, where each implementation handles the http stuff: https://github.com/judoscale/judoscale-java/compare/ca-refactor-api-client

adamlogic

Thanks!

adamlogic · 2026-02-03T15:01:44Z

judoscale-spring-boot-2-starter/src/main/java/com/judoscale/spring/JudoscaleConfig.java

-        String configuredUrl = getApiBaseUrl();
-        return configuredUrl != null && !configuredUrl.trim().isEmpty();
-    }
+public class JudoscaleConfig extends ConfigBase {


yeah, it's the @ConfigurationProperties line above that's specific to Spring Boot.

@ConfigurationProperties is Spring Boot's way of automatically binding external configuration to Java objects. With @ConfigurationProperties(prefix = "judoscale"):

# application.properties judoscale.api-base-url=https://api.judoscale.com/abc123

or environment variables:

JUDOSCALE_URL=https://api.judoscale.com/abc123

...automatically get mapped to the corresponding setters (setApiBaseUrl(), etc.).

adamlogic · 2026-02-03T15:09:15Z

judoscale-core/src/main/java/com/judoscale/core/ReportBuilder.java

+        ObjectNode adapters = objectMapper.createObjectNode();
+        ObjectNode springBootAdapter = objectMapper.createObjectNode();
+        springBootAdapter.put("adapter_version", adapterVersion);
+        adapters.set("judoscale-spring-boot", springBootAdapter);


Yes definitely and this was an oversight. Core should not have any knowledge about the SpringBootAdapter. Good catch!

adamlogic · 2026-02-03T15:10:59Z

judoscale-spring-boot-2-starter/src/main/java/com/judoscale/spring/JudoscaleApiClient.java

-    private static final ObjectMapper objectMapper = new ObjectMapper();
    private static final int MAX_RETRIES = 3;
-    private static final String ADAPTER_VERSION = loadAdapterVersion();
+    private static final String ADAPTER_VERSION = ReportBuilder.loadAdapterVersion(JudoscaleApiClient.class);


The challenge with the API client is that our core library needs to support Java 8 as does the Spring Boot 2 starter, but the Spring Boot starter can use the built-in HTTP client from Java 11. For now I've kept them separate.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

judoscale-core/src/main/java/com/judoscale/core/ReportBuilder.java

Extract common functionality into core

79c2ff8

adamlogic marked this pull request as ready for review February 3, 2026 12:51

carlosantoniodasilva reviewed Feb 3, 2026

View reviewed changes

adamlogic commented Feb 3, 2026

View reviewed changes

cursor bot reviewed Feb 3, 2026

View reviewed changes

judoscale-core/src/main/java/com/judoscale/core/ReportBuilder.java Show resolved Hide resolved

adamlogic added 2 commits February 3, 2026 11:08

Fix adapter metadata in reports

e908771

cleanup

6df6964

adamlogic force-pushed the am-extract-to-core branch from e02864c to 6df6964 Compare February 3, 2026 16:11

adamlogic merged commit 24a11db into main Feb 3, 2026
3 checks passed

github-actions bot mentioned this pull request Feb 3, 2026

chore(main): release judoscale-java 0.1.4 #8

Merged

Conversation

adamlogic commented Feb 2, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlosantoniodasilva left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlosantoniodasilva Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamlogic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adamlogic commented Feb 2, 2026 •

edited by cursor bot

Loading

carlosantoniodasilva Feb 3, 2026 •

edited

Loading