-
Notifications
You must be signed in to change notification settings - Fork 0
Include container and pid metadata in reports #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
carlosantoniodasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks right to me 👍, thanks for handling it!
#122) With this, it will be possible to provide a `JUDOSCALE_CONTAINER` env var to setup the runtime container when using custom setups, or to override the default logic for a platform in case it's necessary. - Ruby: judoscale/judoscale-ruby#261 - Python: #122 - Node: judoscale/judoscale-node#88 - Java: judoscale/judoscale-java#7
#88) With this, it will be possible to provide a `JUDOSCALE_CONTAINER` env var to setup the runtime container when using custom setups, or to override the default logic for a platform in case it's necessary. - Ruby: judoscale/judoscale-ruby#261 - Python: judoscale/judoscale-python#122 - Node: #88 - Java: judoscale/judoscale-java#7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
judoscale-core/src/main/java/com/judoscale/core/ReportBuilder.java
Outdated
Show resolved
Hide resolved
9eaf016 to
3fac07c
Compare
e02864c to
6df6964
Compare
3fac07c to
0596779
Compare
0596779 to
b2ae21c
Compare
New
JUDOSCALE_CONTAINERsupport:Note
Medium Risk
Changes the report payload schema and touches runtime/environment detection logic, which could affect downstream API expectations and container ID parsing across hosts.
Overview
Metrics reports now include runtime metadata by adding
containerandpidfields to the JSON payload, and updating Spring Boot API clients to pass through the detected container identifier.ConfigBasenow detects a runtime container ID fromJUDOSCALE_CONTAINER(or platform-specific env vars like Heroku/Render/ECS/Fly/Railway) and exposes it viagetRuntimeContainer(). Builds forjudoscale-coreandjudoscale-spring-boot-2-starteralso enforce Java 8 API compatibility viajavac --release 8, and tests are updated/added to cover the new fields and null/empty handling.Written by Cursor Bugbot for commit b2ae21c. This will update automatically on new commits. Configure here.