Skip to content

Add support to JUDOSCALE_CONTAINER ENV var for custom containers #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosantoniodasilva merged 1 commit into from
Feb 3, 2026
Merged

Add support to JUDOSCALE_CONTAINER ENV var for custom containers #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions judoscale/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ def __init__(

@classmethod
def initialize(cls, env: Mapping = os.environ):
if env.get("DYNO"):
if env.get("JUDOSCALE_CONTAINER"):
return cls.for_custom(env)
elif env.get("DYNO"):
return cls.for_heroku(env)
elif env.get("RENDER_INSTANCE_ID"):
return cls.for_render(env)
Expand All @@ -56,7 +58,7 @@ def initialize(cls, env: Mapping = os.environ):
elif env.get("RAILWAY_REPLICA_ID"):
return cls.for_railway(env)
else:
return cls.for_custom(env)
return cls.for_unknown(env)
Copy link
Member Author

@carlosantoniodasilva carlosantoniodasilva Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'm refactoring this in a follow-up PR: #123


@classmethod
def for_heroku(cls, env: Mapping):
Expand Down Expand Up @@ -93,6 +95,12 @@ def for_railway(cls, env: Mapping):

@classmethod
def for_custom(cls, env: Mapping):
runtime_container = RuntimeContainer(env["JUDOSCALE_CONTAINER"])
api_base_url = env.get("JUDOSCALE_URL")
return cls(runtime_container, api_base_url, env)

@classmethod
def for_unknown(cls, env: Mapping):
return cls(RuntimeContainer(""), env.get("JUDOSCALE_URL"), env)

@property
Expand Down
21 changes: 21 additions & 0 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,27 @@ def test_on_railway(self):
assert config["API_BASE_URL"] == "https://adapter.judoscale.com/api/1234567890"

def test_on_custom(self):
fake_env = {
"JUDOSCALE_CONTAINER": "my-custom-container",
"JUDOSCALE_URL": "https://adapter.judoscale.com/api/1234567890",
}
config = Config.initialize(fake_env)

assert config["RUNTIME_CONTAINER"] == "my-custom-container"
assert config["LOG_LEVEL"] == "WARN"
assert config["API_BASE_URL"] == "https://adapter.judoscale.com/api/1234567890"

def test_on_custom_takes_precedence(self):
fake_env = {
"JUDOSCALE_CONTAINER": "my-custom-container",
"DYNO": "web.1",
"JUDOSCALE_URL": "https://adapter.judoscale.com/api/1234567890",
}
config = Config.initialize(fake_env)

assert config["RUNTIME_CONTAINER"] == "my-custom-container"

def test_on_unknown(self):
fake_env = {"JUDOSCALE_URL": "https://adapter.judoscale.com/api/1234567890"}
config = Config.initialize(fake_env)

Expand Down