Refactor config init #123
Merged
Refactor config init #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let Config initialize itself with JUDOSCALE_URL from all containers / platforms, and only on Render where we may need the legacy fallback we can check whether API_BASE_URL was set, and if not set it with the legacty URL based on the service/instance. This better matches how the other packages initializes the config, and simplifies this flow a bit, since the platforms all respect JUDOSCALE_URL when set.
Very little change between these, and it feels more work to keep separate methods than it is for them to share a single init method that we can refactor further.
carlosantoniodasilva
force-pushed
the
ca-refactor-config-init
branch
from
29fbbcd to
3c49150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let Config initialize itself with
JUDOSCALE_URLby default, and check for the need to set the URL for the legacy Render support as a last step.Inline all per-platform initialization logic to simplify. Very little change between them, and it feels more work to maintain separate methods and keep adding to them when they're mostly the same.
This better matches how the other packages initializes the config, and simplifies this flow a bit, since the platforms all respect
JUDOSCALE_URLwhen set.