Conversation
They're still running Rails 7.1 so we should eventually upgrade, but this ensures they have the latest at least on that series, and the latest specific framework they're testing too.
carlosantoniodasilva
force-pushed
the
ca-versions
branch
from
bf2f903 to
22d3910
Compare
Only run the main Gemfiles with Ruby 4, since we can't guarantee compatibility with older versions of anything we don't control.
Resque 3 no longer supports Ruby 2.7, and this guarantees test support for both major versions for now.
carlosantoniodasilva
force-pushed
the
ca-versions
branch
from
8c8e136 to
643a150
Compare
We require logger but is no longer a default gem in Ruby 4.0, but rather a bundled gem, which means we need to make sure it's always installed, by making it an explicit dependency now.
We'll keep support to Ruby 3.1, effectively testing / supporting 5 major versions going forward.
We can no longer support it due to the Ruby requirement, plus its last release was almost 4 years ago.
There's no Ruby requirement here, but I think it just makes sense to support only v1+ going forward. I wouldn't expect anyone to be running SolidQueue v0.3 at this point, which was released almost 2 years ago, given that they've released the first major 1.0 later that year, and a few more versions after that. Anyone jumping into SolidQueue would likely have kept up-to-date with the new versions at least until v1, so we're gonna require at least it.
We no longer need to constrain the standard version because we don't support Ruby 2.x anymore. Apply Ruby 3.1 rules since that's our lower supported version. Ref.: 5c74e7b
carlosantoniodasilva
force-pushed
the
ca-versions
branch
from
e1d8f6b to
54fab1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loggergem (no longer a default gem)