-
Notifications
You must be signed in to change notification settings - Fork 39
docs(haskell): add documentation for setup and usage of haskell provider #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b5b4efb to
cfa7a73
Compare
cfa7a73 to
7e712ac
Compare
| inputs.superposition.haskellFlakeProjectModules.output | ||
| ]; | ||
|
|
||
| basePackages = pkgs.haskell.packages.ghc96; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The development shell uses GHC 9.4 ( at line number 67) while the project is configured for GHC 9.6. This can cause confusing build failures. Can we check ?
| Add the following dependencies to your .cabal file: | ||
|
|
||
| ```cabal | ||
| monad-logger-aeson == 0.4.1.3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is too strict , Can we change this to : monad-logger-aeson ^>= 0.4.1
| threadDelay 4000000 | ||
| OpenFeature.setDefaultProvider provider | ||
| client <- OpenFeature.createClient | ||
| v <- expectRight <$> OpenFeature.getBoolValue client (pack "k1") mempty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example uses "k1" but doesn't explain what flag keys should exist
| ```bash | ||
| cd /tmp | ||
|
|
||
| curl -L "https://github.com/juspay/superposition/releases/download/{version-you-want-to-use}/superposition_core-${1}.zip" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the v prefix here as well ?
Problem
Missing provider docs
Solution
Added docs for setup and usage of provider