Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55adf2878b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let client_start = tokio::time::Instant::now(); | ||
| let client = Client::builder() | ||
| .no_proxy() | ||
| .timeout(Duration::from_secs(5)) // Allow Chrome time to bring up /json/version on fresh launch |
There was a problem hiding this comment.
Preserve proxies for non-local CDP discovery
Calling Client::builder().no_proxy() here disables all proxy use for discover_ws_via_host_port, not just localhost. If a user sets connect_host to a remote Chrome endpoint that is only reachable via HTTP(S)_PROXY (common in corporate networks), discovery will now bypass the proxy and fail to reach /json/version. The change is intended for localhost, but it regresses remote/proxied CDP setups by forcing direct connections.
Useful? React with 👍 / 👎.
Summary
/json/versiondiscovery./diffcontext lines align correctly.Tests
cargo test -p code-browser --manifest-path code-rs/Cargo.toml --libcargo test -p code-tui --manifest-path code-rs/Cargo.toml --lib history_cell::diff::tests::diff_record_strips_context_prefix_space./build-fast.shFixes #508
Fixes #473