Stringify metadata object for html content#205
Merged
just1and0 merged 1 commit intojust1and0:mainfrom Feb 6, 2025
Merged
Conversation
Owner
|
Hi @quartusk good spot! I will approve once it passes CI checks. I would also recommend you read the contribution docs to better understand how to name your commits. This is important as CI will not publish your changes to npm if this isn't done right. |
Contributor
Author
|
Sorry I missed the CONTRIBUTING.md at first glance. I can create a new pull request if that helps speed things up |
Owner
|
Nah you don't need a new pr And that should do it |
Contributor
Author
|
Thanks, I've amended the commit message |
just1and0
approved these changes
Feb 6, 2025
Owner
|
@all-contributors add @quartusk for code |
Contributor
|
I've put up a pull request to add @quartusk! 🎉 |
|
🎉 This PR is included in version 4.6.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the optional metadata object is passed, the object was never converted to a string representation, which results in the html content using the default serialization and looking like this:
After applying JSON.stringify to the object, we'll get a valid string representation: