fix(RNPSW)-add-safearea-to-webview-modal#223
Conversation
|
@just1and0 please review |
|
Is this getting approved anytime soon? @just1and0 |
|
Alright, thanks |
|
@Reechychukz @Harithmetic1 As stated in the contribution guidelines, please ensure you add me as a reviewer when opening a PR, as this is how I receive notifications to review it. I’ve gone ahead and added myself this time, but please remember to do so in the future. Thanks @Harithmetic1 for working on this PR — appreciate your contribution! 🙌 |
just1and0
left a comment
There was a problem hiding this comment.
Thanks for making this change, @Harithmetic1.
Just a minor review: it seems your code formatter is modifying the entire component, which makes it harder to see the actual changes you made.
Could you undo the Prettier-related changes and only edit the specific sections of code you intended to update?
|
Sure, I’ll get it done ASAP. Thank you! |
|
Hey @just1and0 I have made the requested changes on the PR. It should only show the changes I made. |
|
@all-contributors add @Harithmetic1 for code |
|
I've put up a pull request to add @Harithmetic1! 🎉 |
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
I added a SafeAreaView to the Paystack WebView modal to fix the following issue
Issue URL
[Webview goes under StatusBar and SafeArea is not applied.
#215](#215)
Before and After
Add Image/video/gifs of changes

Before:
After:
