jetcd leaves behind non-daemon threads belonging to http client #8

timboudreau · 2014-03-19T22:22:26Z

Great project, but it's a little annoying that it leaves behind non-daemon threads that can keep a program from exiting or keep resources tied up. In particular, if you use a framework which allows for cleanly shutting down everything without killing the VM, anything that leaves behind stuff like this is problematic.

I've patched jetcd to allow the HTTP client to be passed in, to avoid that situation.

(sorry about also including the pom.xml - I can't find a way to exclude that commit from my pull request)

…thout leaving behind non-daemon threads

…for continuous builds without a harness to start it

…never to reopen an index file

…implementation

…-central

…ns; deal with backward incompatibilities in the vertx async postgres client (sigh).

…ional interfaces for consistency, add util/subscriptions, remove original bunyan-java, bump library versions

… 15's javac; all tests pass on both

…istry, which improves shutdown time and build-times

…ure building on apple silicon; library version updates

Version Changes --------------- * com.mastfrog:annotation-tools: 2.8.3.4->2.8.4 * com.mastfrog:automodule-inject: 1.0->1.0.1 * com.mastfrog:colors: 2.8.3.4->2.8.4 * com.mastfrog:function: 2.8.3.1->2.8.4 * com.mastfrog:giulius-jdbc: 2.8.3->2.8.4 * com.mastfrog:java-vogon: 2.8.3.1->2.8.4 * com.mastfrog:mastfrog-parent: 2.8.3->2.8.4 * com.mastfrog:maven-merge-configuration: 2.8.3.4->2.8.4 * com.mastfrog:revision-info-plugin: 0.21->0.21.1 * com.mastfrog:revision-info-plugin: 2.8.3->2.8.4 * com.mastfrog:smart-jar-merge: 2.8.3.5->2.8.4 * com.mastfrog:swing-miscellaneous: 2.8.3.5->2.8.4 * com.mastfrog:util-strings: 2.8.3.1->2.8.4 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.8.3` ⟶ `2.8.4` * *jackson.version* - `2.13.4` ⟶ `2.8.4` * *trackerapi.version* - `1.0` ⟶ `2.8.4` * *selenium.version* - `3.141.59` ⟶ `2.8.4` * *mastfrog.version* - `2.8.3` ⟶ `2.8.4` ##### Provenance Generated by cactus: *cactus-git* version _1.5.30_. * Mojo: BumpVersionMojo * Generation-Time: 2022-09-10T07:15:57Z * Plugin-Build: yellow rabbit * Plugin-Date: 2022.09.10 * Plugin-Commit: 421cae558a013d1d97a7e968ec38d732672045f5 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.0.1->1.0.2 * com.mastfrog:giulius-jdbc: 2.8.4->2.8.5 * com.mastfrog:mastfrog-parent: 2.8.4->2.8.5 * com.mastfrog:revision-info-plugin: 0.21.1->0.21.2 * com.mastfrog:revision-info-plugin: 2.8.4->2.8.5 * com.mastfrog:testproject-a: 2.8.3->2.8.4 * com.mastfrog:testproject-b: 2.8.3->2.8.4 * com.mastfrog:testproject-c: 2.8.3->2.8.4 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *jackson.version* - `2.13.4` ⟶ `2.8.5` * *selenium.version* - `3.141.59` ⟶ `2.8.5` * *mastfrog.version* - `2.8.4` ⟶ `2.8.5` * *trackerapi.version* - `1.0` ⟶ `2.8.5` * *mastfrog.version* - `2.8.4` ⟶ `2.8.5` ##### Provenance Generated by cactus: *cactus-git* version _1.5.29_. * Mojo: BumpVersionMojo * Generation-Time: 2022-09-10T08:10:09Z * Plugin-Build: yellow rhino * Plugin-Date: 2022.09.09 * Plugin-Commit: b816224000b13e96c26499c7110b67895868f2cd * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.0.2->1.0.3 * com.mastfrog:giulius-jdbc: 2.8.5->2.8.6 * com.mastfrog:java-vogon: 2.8.5.2->2.8.6 * com.mastfrog:mastfrog-parent: 2.8.5->2.8.6 * com.mastfrog:revision-info-plugin: 0.21.2->0.21.3 * com.mastfrog:revision-info-plugin: 2.8.5->2.8.6 * com.mastfrog:testproject-a: 2.8.4->2.8.5 * com.mastfrog:testproject-b: 2.8.4->2.8.5 * com.mastfrog:testproject-c: 2.8.4->2.8.5 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.8.5` ⟶ `2.8.6` * *selenium.version* - `3.141.59` ⟶ `2.8.6` * *jackson.version* - `2.13.4` ⟶ `2.8.6` * *mastfrog.version* - `2.8.5` ⟶ `2.8.6` * *trackerapi.version* - `1.0` ⟶ `2.8.6` ##### Provenance Generated by cactus: *cactus-git* version _1.5.31_. * Mojo: BumpVersionMojo * Generation-Time: 2022-09-23T05:13:04Z * Plugin-Build: yellow rabbit * Plugin-Date: 2022.09.10 * Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.0->1.0.1 * com.mastfrog:giulius-jdbc: 2.8.6->2.8.7 * com.mastfrog:mastfrog-parent: 2.8.6->2.8.7 * com.mastfrog:revision-info-plugin: 0.21->0.21.1 * com.mastfrog:revision-info-plugin: 2.8.6->2.8.7 * com.mastfrog:testproject-a: 2.8.5->2.8.6 * com.mastfrog:testproject-b: 2.8.5->2.8.6 * com.mastfrog:testproject-c: 2.8.5->2.8.6 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.8.6` ⟶ `2.8.7` * *selenium.version* - `3.141.59` ⟶ `2.8.7` * *trackerapi.version* - `1.0` ⟶ `2.8.7` * *mastfrog.version* - `2.8.6` ⟶ `2.8.7` * *jackson.version* - `2.13.4` ⟶ `2.8.7` ##### Provenance Generated by cactus: *cactus-git* version _1.5.31_. * Mojo: BumpVersionMojo * Generation-Time: 2022-10-12T21:48:06Z * Plugin-Build: yellow rabbit * Plugin-Date: 2022.09.10 * Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:acteur: 2.8.7.1->2.8.8 * com.mastfrog:acteur-headers: 2.8.7.1->2.8.8 * com.mastfrog:automodule-inject: 1.0->1.0.1 * com.mastfrog:giulius-jdbc: 2.8.7->2.9.0 * com.mastfrog:java-vogon: 2.8.7.1->2.8.8 * com.mastfrog:mastfrog-parent: 2.8.7->2.9.0 * com.mastfrog:revision-info-plugin: 0.21->0.21.1 * com.mastfrog:revision-info-plugin: 2.8.7->2.9.0 * com.mastfrog:testproject-a: 2.8.6->2.8.7 * com.mastfrog:testproject-b: 2.8.6->2.8.7 * com.mastfrog:testproject-c: 2.8.6->2.8.7 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.8.7` ⟶ `2.9.0` * *mastfrog.version* - `2.8.7` ⟶ `2.9.0` * *jackson.version* - `2.13.4` ⟶ `2.9.0` * *trackerapi.version* - `1.0` ⟶ `2.9.0` * *selenium.version* - `3.141.59` ⟶ `2.9.0` ##### Provenance Generated by cactus: *cactus-git* version _1.5.31_. * Mojo: BumpVersionMojo * Generation-Time: 2022-10-18T05:10:33Z * Plugin-Build: yellow rabbit * Plugin-Date: 2022.09.10 * Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2 * Plugin-Repo-Clean: true

…of acteur-headers and acteur-util' Affected Checkouts ------------------ * acteur-modules/acteur-parent * giulius-modules/giulius-parent * giulius-selenium-tests-modules/giulius-selenium-tests-parent * giulius-web-modules/giulius-web-parent * acteur-auth * acteur-timetracker * acteur-tutorial * blather * blurt * bunyan-java-v2 * generic-web-api * giulius-settings-etcd * jetcd * netty-http-client * numble * (root) ##### Provenance Generated by cactus: *cactus-git* version _1.5.31_. * Mojo: CommitMojo * Generation-Time: 2022-10-19T03:41:38Z * Plugin-Build: yellow rabbit * Plugin-Date: 2022.09.10 * Plugin-Commit: f32552996bf3511e8901928b6467df125bdebbd2 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.2->1.2.1 * com.mastfrog:mastfrog-parent: 2.9.0->2.9.1 * com.mastfrog:revision-info-plugin: 0.20->0.20.1 * com.mastfrog:revision-info-plugin: 2.8.2->2.8.3 * com.mastfrog:revision-info-plugin: 2.9.0->2.9.1 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.9.0` ⟶ `2.9.1` * *mastfrog.version* - `2.9.0` ⟶ `2.9.1` * *trackerapi.version* - `1.0` ⟶ `2.9.1` * *selenium.version* - `3.141.59` ⟶ `2.9.1` ##### Provenance Generated by cactus: *cactus-maven-plugin* version _1.5.36_. * Mojo: BumpVersionMojo * Generation-Time: 2022-10-28T05:08:48Z * Plugin-Build: yellow light-bulb * Plugin-Date: 2022.10.26 * Plugin-Commit: 45c71cee60ee9a335b03d4e55e4427c4fdabd09d * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.2->1.2.1 * com.mastfrog:mastfrog-parent: 2.9.1->2.9.2 * com.mastfrog:revision-info-plugin: 0.22->0.22.1 * com.mastfrog:revision-info-plugin: 2.9.1->2.9.2 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.9.1` ⟶ `2.9.2` * *mastfrog.version* - `2.9.1` ⟶ `2.9.2` ##### Provenance Generated by cactus: *cactus-maven-plugin* version _1.5.35_. * Mojo: BumpVersionMojo * Generation-Time: 2022-11-11T03:50:51Z * Plugin-Build: yellow laptop * Plugin-Date: 2022.10.20 * Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.2.1->1.2.2 * com.mastfrog:mastfrog-parent: 2.9.2->2.9.3 * com.mastfrog:revision-info-plugin: 0.22.1->0.22.2 * com.mastfrog:revision-info-plugin: 2.9.2->2.9.3 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.9.2` ⟶ `2.9.3` * *mastfrog.version* - `2.9.2` ⟶ `2.9.3` ##### Provenance Generated by cactus: *cactus-maven-plugin* version _1.5.35_. * Mojo: BumpVersionMojo * Generation-Time: 2022-11-20T13:15:59Z * Plugin-Build: yellow laptop * Plugin-Date: 2022.10.20 * Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.2->1.2.1 * com.mastfrog:mastfrog-parent: 2.9.3->2.9.4 * com.mastfrog:revision-info-plugin: 0.22->0.22.1 * com.mastfrog:revision-info-plugin: 2.9.3->2.9.4 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.9.3` ⟶ `2.9.4` * *mastfrog.version* - `2.9.3` ⟶ `2.9.4` ##### Provenance Generated by cactus: *cactus-maven-plugin* version _1.5.35_. * Mojo: BumpVersionMojo * Generation-Time: 2022-11-28T06:19:23Z * Plugin-Build: yellow laptop * Plugin-Date: 2022.10.20 * Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.2->1.2.1 * com.mastfrog:mastfrog-parent: 2.9.4->2.9.5 * com.mastfrog:revision-info-plugin: 0.23->0.23.1 * com.mastfrog:revision-info-plugin: 2.9.4->2.9.5 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.9.4` ⟶ `2.9.5` * *mastfrog.version* - `2.9.4` ⟶ `2.9.5` ##### Provenance Generated by cactus: *cactus-maven-plugin* version _1.5.35_. * Mojo: BumpVersionMojo * Generation-Time: 2023-02-13T04:20:44Z * Plugin-Build: yellow laptop * Plugin-Date: 2022.10.20 * Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.2->1.2.1 * com.mastfrog:mastfrog-parent: 2.9.5->2.9.6 * com.mastfrog:revision-info-plugin: 0.23->0.23.1 * com.mastfrog:revision-info-plugin: 2.9.5->2.9.6 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.9.5` ⟶ `2.9.6` * *mastfrog.version* - `2.9.5` ⟶ `2.9.6` ##### Provenance Generated by cactus: *cactus-maven-plugin* version _1.5.35_. * Mojo: BumpVersionMojo * Generation-Time: 2023-02-20T03:49:44Z * Plugin-Build: yellow laptop * Plugin-Date: 2022.10.20 * Plugin-Commit: 7622e64b4f177618889d793eacbefc57173eabc6 * Plugin-Repo-Clean: true

Version Changes --------------- * com.mastfrog:automodule-inject: 1.2->1.2.1 * com.mastfrog:mastfrog-parent: 2.9.6->2.9.7 * com.mastfrog:revision-info-plugin: 0.23->0.23.1 * com.mastfrog:revision-info-plugin: 2.9.4->2.9.5 * com.mastfrog:revision-info-plugin: 2.9.6->2.9.7 Property Changes ---------------- * com.mastfrog:mastfrog-parent * *mastfrog.version* - `2.9.6` ⟶ `2.9.7` * *mastfrog.version* - `2.9.6` ⟶ `2.9.7` ##### Provenance Generated by cactus: *cactus-maven-plugin* version _1.5.45_. * Mojo: BumpVersionMojo * Generation-Time: 2023-02-21T09:24:00Z * Plugin-Build: yellow dune-buggy * Plugin-Date: 2022.11.02 * Plugin-Commit: c66f67cfba0b6b556c8a9f3907e02f54ca8a7a70 * Plugin-Repo-Clean: true

timboudreau and others added 30 commits March 19, 2014 18:13

Allow passing in http client so it's possible to cleanly shut down wi…

5afd78d

…thout leaving behind non-daemon threads

Version

fa7161c

Use less resource-consumptive netty instead of apache http client

b46bf79

Cleanup

e178c56

Source level 1.7

c4d0eb7

Versions

070a8c2

Client version

efb1fe1

Client version

832dc36

Client version

3b1c63e

Version

c434e4c

Skip tests by default - requires running local etcd, not appropriate …

f22dfc3

…for continuous builds without a harness to start it

Make readme reflect reality

c40c861

Update library versions

4378442

Bugfix in ServerBuilder for scope bindings

6443da4

Add cookie store support to http client

38fb369

Fix dependency

8d4999e

Fix same send/receive port in http client; fix annotation processors …

9a69a44

…never to reopen an index file

Add numble, bump to 1.5.0 - switching source level to 1.8

37e6cb5

Pom cleanup

7085f61

HttpClient updates

ee86dfb

Bump version to 1.5.2

09d3aa7

Bump version; give Output a way to close deferred writes

a5e2707

Update to 1.5.4; timeout fixes in netty-http-client

93e9d17

Acteur 1.6 with factored out and rewritten engine; simplified scopes …

7f309d4

…implementation

Back to JDK 7. Sigh.

ab93d00

Release 1.6.0

6ada1e3

-m

9907817

Bump version to 1.6.1.1-dev to accomodate logging changes

16d06cf

A provision for simple suites with selenium

beb57b8

Update to Netty 4.0.28 and Guice 4.0 release

0005c22

timboudreau and others added 30 commits December 4, 2019 14:31

Update simplevalidation version so all dependencies are ones in maven…

d528767

…-central

Bump version to 2.6.7

08acfc3

Bump version

2f4f84c

Release 2.6.9

eb9a8a4

Annotation tools delegate processor improvements; bump library versio…

efd3d9b

…ns; deal with backward incompatibilities in the vertx async postgres client (sigh).

Bump version (hotfix strings 2.6.11.1 precedes this)

bbf7637

v2.6.12

a2a550e

v2.6.13

4c6c9f7

v2.7.0 - remove some obsolete projects, correct method names in funct…

5e2ce46

…ional interfaces for consistency, add util/subscriptions, remove original bunyan-java, bump library versions

Version 2.7.1

936b615

v2.7.2 - annotation processor fixes for differences between jdk 8 and…

385a003

… 15's javac; all tests pass on both

v2.7.3

858456d

A number of optimizations; in particular a rewrite of ShutdownHookReg…

9e7cd23

…istry, which improves shutdown time and build-times

Remove obsolete repository sections from poms; misc test fixes to ens…

ea49e27

…ure building on apple silicon; library version updates

With some library updates, bump to v2.8.1

399493f

v2.8.2 with automatic module names

1812dba

v2.8.3

0a2dc5c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

jetcd leaves behind non-daemon threads belonging to http client #8

jetcd leaves behind non-daemon threads belonging to http client #8

Uh oh!

timboudreau commented Mar 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jetcd leaves behind non-daemon threads belonging to http client #8

Are you sure you want to change the base?

jetcd leaves behind non-daemon threads belonging to http client #8

Uh oh!

Conversation

timboudreau commented Mar 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant