Consistent, language independent logic#46
Open
YaraslauZhylko wants to merge 2 commits intojwadhams:masterfrom
Open
Consistent, language independent logic#46YaraslauZhylko wants to merge 2 commits intojwadhams:masterfrom
YaraslauZhylko wants to merge 2 commits intojwadhams:masterfrom
Conversation
Author
|
@jwadhams , is there a chance you could review and merge this pull request any time soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My code changes to implement consistent, language independent logic described in Issue #44.
All original tests from http://jsonlogic.com still pass successfully.
And I've added my own set of tests called
lanaguage-independent.json(with temporary modified.gitignore) to show how the modified logic works.I can also change the code to only accept a strongly limited set of arguments (see comment nr. 3 in Issue #44).
And as I've mentioned, I can modify the Python port (json-logic-py) to make it follow all latest changes.