Conversation
in the Customization section.
|
I really like this idea, I think it belongs in the |
There was a problem hiding this comment.
The README already refers to https://jsonlogic.com/add_operation.html which has lots of info.
It might be beneficial to leave the add_operation out of the readme in favor of the readme being minimal?
Suggested changes commented below -- perhaps the examples from https://jsonlogic.com/add_operation.html could be put here? That is, assuming adding examples in the readme is desired.
| return age < 65; | ||
| } | ||
|
|
||
| function greatherThanNumber(age) { |
There was a problem hiding this comment.
This is misleading. greatherThanNumber is actually greaterThanOrEqualToNumber.
| You can perform custom operations on your dataset using `add_operation` | ||
|
|
||
| ```js | ||
| function lessThanNumber(age) { |
There was a problem hiding this comment.
The name lessThanNumber suggests to me that the operation would let you pick which number it is less than. Really this is lessThan65.
|
One additional note: I did test the examples to make sure they work, and they do in fact work. |
3 participants
No description provided.