Skip to content

Fix ifconfig parsing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jsl123 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ifconfig parsing #2

jsl123 wants to merge 2 commits into from

Conversation

@jsl123
Copy link

@jsl123 jsl123 commented Oct 12, 2017

Fixed some small issues...
BTW: Thank you for the script and the necessary information! :-)

Things done

  • Minor markdown fix
  • Made MAC detection more robust. ifconfig is only used as fallback, since most of the time we use ip in this script anyway...
  • Changed installation folder from /usr/bin/ to /usr/sbin since this script may only be run by root as it does change IP addresses. Linux FHS says to install such scripts in a "root only" folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jsl123