Skip to content

Conversation

@acidtib
Copy link

@acidtib acidtib commented Oct 25, 2018

If using :msgpack as a format this error is raised Exception: Missing named tuple key: :msgpack (KeyError)

this pr adds msgpack as a format

Kave.configure do |c|
  c.format = :msgpack
end

@jwoertink
Copy link
Owner

Hey! thanks for submitting this. Definitely one thing I wanted to add. One thing though is that if you're using msgpack, you'd still have to pass in a json accept header, so https://github.com/jwoertink/kave/blob/master/src/kave.cr#L7 this would need to be updated as well. If you figure that out, can you also add a spec to check if it's json or msgpack to make sure it doesn't break the json side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants