Skip to content

Conversation

@ricky9408
Copy link

FIx this issue #1190

Signed-off-by: Sanghyuk Lee <rickg9408@gmail.com>
@EItanya
Copy link
Contributor

EItanya commented Jan 12, 2026

IIRC this used to be necessary, but I can't for the life of me remember why, I will respond again if I can think of it 😆

@ricky9408 ricky9408 requested a review from peterj as a code owner January 13, 2026 01:58
@ricky9408 ricky9408 force-pushed the fix/tools-override branch 2 times, most recently from a827a95 to c2d5eb4 Compare January 13, 2026 02:10
@ricky9408
Copy link
Author

ricky9408 commented Jan 13, 2026

@EItanya
Thanks for the response!

During the CI testing, 1 CI has failed.

Error: 2 errors occurred:
	* clusterrolebindings.rbac.authorization.k8s.io "kagent-getter-rolebinding" already exists
	* clusterrolebindings.rbac.authorization.k8s.io "kagent-writer-rolebinding" already exists


make: *** [Makefile:327: helm-install-provider] Error 1
Error: Process completed with exit code 2.

I investigated the CI logs and I found that both kagent chart and kagent-tools chart are creating same clusterrolebindings.

Reference: https://github.com/kagent-dev/tools/blob/main/helm/kagent-tools/templates/clusterrolebinding.yaml

So that I added this commit for this conflict.

May I ask for this to be checked as well? Thanks.

Signed-off-by: Sanghyuk Lee <ricky9408@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants