Skip to content

Conversation

@junhuanchen
Copy link

No description provided.

@kaniteru
Copy link
Owner

Thank you so much for your pull request!

After reviewing it, I noticed that the destructor in the base class Socket already performs the same function as UdpClient::stop().

Socket::~Socket() {
if (m_socket != KANI_INVALID_SOCKET) {
KANI_CLOSE_SOCKET(m_socket);
}

class UdpClient : public Socket, public IClient {

void UdpClient::stop() {
if (m_socket == KANI_INVALID_SOCKET) {
return;
}
KANI_CLOSE_SOCKET(m_socket);
m_socket = KANI_INVALID_SOCKET;
}

As a result, I won’t be merging this change, but I appreciate your effort in suggesting it.

I also want to express how thrilled I am that you are the first person to leave a pull request on my repo :p
Your contribution to my project mean a lot to me, and I truly appreciate it.
Thank you once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants