Skip to content

Automated fix for refs/heads/mcs #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: mcs
Choose a base branch
from
Open

Automated fix for refs/heads/mcs #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/cpp/interop/interop_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,7 +1402,7 @@ bool InteropClient::DoMcsConnectionScaling() {
if (!stream2->Read(&response2)) {
LOG(ERROR) << "DoMcsConnectionScaling(): stream2->Read() failed.";
return TransientFailureOrAbort();
}
}
std::string peerSocketAddressInCall2 = response2.peer_socket_address();

// The same connection should have been used for both streams.
Expand All @@ -1424,7 +1424,7 @@ bool InteropClient::DoMcsConnectionScaling() {
if (!stream3->Read(&response3)) {
LOG(ERROR) << "DoMcsConnectionScaling(): stream3->Read() failed.";
return TransientFailureOrAbort();
}
}
std::string peerSocketAddressInCall3 = response3.peer_socket_address();
GRPC_CHECK(!peerSocketAddressInCall3.empty());

Expand Down
26 changes: 16 additions & 10 deletions tools/run_tests/run_interop_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1825,12 +1825,16 @@ def aggregate_http2_results(stdout):
if "all" in args.language or l in args.language
)
if not languages_for_mcs_cs:
print('MCS connection scaling tests will be skipped since none of the supported client languages for MCS connection scaling testcases was specified')
if args.server != 'java':
print('Using java for MCS connection scaling server to be used by all MCS connection scaling clients.')
print(
"MCS connection scaling tests will be skipped since none of the supported client languages for MCS connection scaling testcases was specified"
)
if args.server != "java":
print(
"Using java for MCS connection scaling server to be used by all MCS connection scaling clients."
)
mcs_server_jobspec = server_jobspec(
_LANGUAGES['java'],
docker_images.get('java'),
_LANGUAGES["java"],
docker_images.get("java"),
args.transport_security,
manual_cmd_log=server_manual_cmd_log,
set_max_concurrent_streams_limit=True,
Expand All @@ -1842,15 +1846,17 @@ def aggregate_http2_results(stdout):
for language in languages_for_mcs_cs:
test_job = cloud_to_cloud_jobspec(
language,
'max_concurrent_streams_connection_scaling',
'java-mcs',
'localhost',
"max_concurrent_streams_connection_scaling",
"java-mcs",
"localhost",
mcs_server_job.mapped_port(_DEFAULT_SERVER_PORT),
docker_image=docker_images.get(str(language)),
transport_security=args.transport_security,
manual_cmd_log=client_manual_cmd_log,
add_env={'GRPC_EXPERIMENTAL_MAX_CONCURRENT_STREAMS_CONNECTION_SCALING': 'true',
'GRPC_EXPERIMENTS': 'subchannel_connection_scaling'},
add_env={
"GRPC_EXPERIMENTAL_MAX_CONCURRENT_STREAMS_CONNECTION_SCALING": "true",
"GRPC_EXPERIMENTS": "subchannel_connection_scaling",
},
)
jobs.append(test_job)

Expand Down