Add two new commands: ListApps() and KeyEnter(). Update pairing permissions.#3
Open
kevinms wants to merge 1 commit intokaperys:masterfrom
Open
Add two new commands: ListApps() and KeyEnter(). Update pairing permissions.#3kevinms wants to merge 1 commit intokaperys:masterfrom
kevinms wants to merge 1 commit intokaperys:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thanks for the great library! I've had a lot of fun with it.
I found my TV model didn't respond to the KeyOk() command. Through some trial and error, it did respond when an "ENTER" button request was sent. I created a new command called KeyEnter() for that one.
I also added a new command called ListApps() for listing what apps are installed on the TV. With that list of apps, you can turn around and easily use LaunchApp(). Some apps had very non-intuitive names.
I also found that launching apps, pressing the play button, etc. required more permissions to be passed when creating a client key. I added those extra permissions to the pairing.go.