Implement defined behavior for deepcopy #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #89 Surprisingly `deepcopy(mock())` returned `None`. (The reason was that `deepcopy(m)` essentially is `m.__deepcopy__()` and unconfigured mocks return `None` on all method calls.) We generally change that: most but the basic dunder methods inherited from `object` (and except `__call__`) now raise `AttributeError` if unconfigured. This doesn't change a lot in practice but has the side-effect that `hasattr` calls also answer correctly (`False`) in these cases. For dumb mocks this also means that `__deepcopy__` now throws, and hence Python kicks in the default, other implementation of the deepcopy algorithm. For strict mocks, we actually catch the `__deepcopy__` call and raise `RuntimeError` as the `AttributeError` is implicitly caught by `deepcopy`. Note that a deepcopy does not copy or even spin off the expectations or the recorded usage of the mock. Users need to make that manually, e.g. `when(copy).deepcopy(m).thenReturn(n)`.
kaste
force-pushed
the
the-deepcopy-case
branch
from
80a7462 to
5bfcf6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Surprisingly
deepcopy(mock())returnedNone. (The reason was thatdeepcopy(m)essentially ism.__deepcopy__()and unconfigured mocksreturn
Noneon all method calls.)We generally change that: most but the basic dunder methods inherited
from
object(and except__call__) now raiseAttributeErrorifunconfigured. This doesn't change a lot in practice but has the
side-effect that
hasattrcalls also answer correctly (False) inthese cases.
For dumb mocks this also means that
__deepcopy__now throws, and hencePython kicks in the default, other implementation of the deepcopy
algorithm.
For strict mocks, we actually catch the
__deepcopy__call and raiseRuntimeErroras theAttributeErroris implicitly caught bydeepcopy.Note that a deepcopy does not copy or even spin off the expectations
or the recorded usage of the mock. Users need to make that manually,
e.g.
when(copy).deepcopy(m).thenReturn(n).