Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ast_scope/annotator.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,9 @@ def visit_Name(self, node: ast.Name):
GrabVariable(self.scope, node, self.annotation_dict).generic_visit(node)

def visit_ExceptHandler(self, node: ast.ExceptHandler):
assert node.name
self.annotate_intermediate_scope(node, node.name, True)
self.scope.modify(node.name)
if node.name is not None:
self.annotate_intermediate_scope(node, node.name, True)
self.scope.modify(node.name)
visit_all(self, node.type, node.body)

def visit_alias(self, node: ast.alias):
Expand Down
5 changes: 3 additions & 2 deletions ast_scope/pull_scope.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@ def visit_Lambda(self, node: ast.Lambda):
super().generic_visit(node)

def visit_ExceptHandler(self, node: ast.ExceptHandler):
scope = self.pull_scope(node)
scope.add_exception(node)
if node.name is not None:
scope = self.pull_scope(node)
scope.add_exception(node)
super().generic_visit(node)

def visit_comprehension_generic(
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name="ast_scope", # Replace with your own username
version="0.5.1",
version="0.5.2",
author="Kavi Gupta",
author_email="ast_scope@kavigupta.org",
description="Annotates a Python AST with the scope of symbols.",
Expand Down
33 changes: 30 additions & 3 deletions tests/exception_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,40 @@


class ExceptionTests(DisplayAnnotatedTestCase):
def test_multiple_arguments(self):

def test_basic_named(self):
self.assertAnnotationWorks(
"""
{g}def f():
try:
{~f@1:0}z = 1
{~f@1:0}except {g}Exception as e:
{~f@1:0}x = {~f@1:0}e
finally:
{~f@1:0}y = 1
"""
)

def test_no_name(self):
self.assertAnnotationWorks(
"""
{g}def f():
try:
{~f@1:0}z = 1
except {g}Exception:
{~f@1:0}x = 1
"""
)

def test_multiple_exceptions(self):
self.assertAnnotationWorks(
"""
{g}def f():
try:
pass
{~f@1:0}z = 1
{~f@1:0}except {g}Exception as e:
pass
{~f@1:0}x = {~f@1:0}e
{~f@1:0}except {g}ValueError as e2:
{~f@1:0}y = {~f@1:0}e2
"""
)