Implemented Dispose pattern for both Buffer and BufferEvent with no fina... #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inalizers. The user should ensure Disposed is called when no longer needed on the main EV Loop thread. Removed redundant IntPtr allocation in Buffer.cs. BufferEvent delegates now saved as private fields to prevent the GC collecting these. Otherwise the native code calls back to dangling pointers. Added bufferevent_set_timeouts. Fixed ConnectionListener not providing correct IPEndPoint for new connections. Tested OK on Ubuntu. Added EventSyncContext to provide a means for running an EV Loop and for posting other work you want run on the same thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...lizers. The user should ensure Disposed is called when no longer needed on the main EV Loop thread.
Removed redundant IntPtr allocation in Buffer.cs.
BufferEvent delegates now saved as private fields to prevent the GC collecting these. Otherwise the native code calls back to dangling pointers.
Added bufferevent_set_timeouts.
Fixed ConnectionListener not providing correct IPEndPoint for new connections. Tested OK on Ubuntu.
Added EventSyncContext to provide a means for running an EV Loop and for posting other work you want run on the same thread.