Use call instead of execute before system to run external commands

[a-sk]

Before this commit, calling of investigate produced E492: Not an editor command error.

For example I got this error in :message for bash files:
Not an editor command: firefox https://encrypted.google.com/search?q=exec&sitesearch=ss64.com^@

[keith]

Hmm, what else are you changing to make it open with the firefox executable? Did you just override something in this?

[justinmk]

Actually, it is odd that execute was working. execute is for evaling a string of vimscript. Does system(l:command) return a string of vimscript, or is it a shell command?

[keith]

Hmm yea it just returns the string output of the command I think. Which in this case I don't care about.

[keith]

I'm still worried about that being the root of the issue. I saw the same error message a few times during development because of unquoted URLs.

[keith]

I think this is still a pretty safe fix, I don't think it will mess any one up. Do you agree @justinmk

[justinmk]

Yes!

[keith]

@a-sk I'd still like to hear what you did to make it default to using firefox as the executable. I've thought about allowing customization of the commands via variables which may make whatever you did a little easier.

[a-sk]

@Keithbsmiley
I don't. I use use custom xdg-open with a small patch: march-linux/mimi#4
It allows to make this work:
/usr/bin/xdg-open /usr/bin/zeal --query 'asd'
And for urls any xdg-open should work.

And of course, customization of the commands via variables would be nice.

[keith]

Ok cool. So as long as your patch fixed it for you we're good here. And I'll add command customization shortly.

[a-sk]

Ok, thanks :)