properly implemented seeding for BinaryFOVSensor (probably)#39
Merged
properly implemented seeding for BinaryFOVSensor (probably)#39
Conversation
Collaborator
|
👍 |
rvega10
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements proper seeding for the BinaryFOVSensor class to align with a new seeding system introduced in a previous commit. The changes establish a consistent RNG hierarchy where sensors can inherit random number generators from their parent or agent, falling back to system time if neither is available.
- Updates BinaryFOVSensor to use the new seeding system by passing seed parameter to parent constructor
- Replaces deprecated numpy RandomState calls with modern Generator API
- Adds seeding infrastructure to AbstractSensor base class with fallback hierarchy
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/swarmsim/sensors/BinaryFOVSensor.py | Removes manual seed handling, passes seed to parent, updates RNG calls to use self.rng |
| src/swarmsim/sensors/AbstractSensor.py | Adds seed parameter and set_seed method implementing the RNG hierarchy |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't update BinaryFOVSensor to use the new seeding system back when I introduced in 6f0ab4c.
Now, BinaryFOVSensor should attempt to seed its own RNG in this order:
seedarg inBinaryFOVSensor.__init__()(orseedin yaml config)BinaryFOVSensor.parent.rngBinaryFOVSensor.agent.rngnp.random.default_rng(None))BinaryFOVSensor.rngis now the rng that should be used within the class/instance, rather than RandomState np.random.random which is now deprecated.