Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new sensor, and also separates two concerns within BinaryFOVSensor:
class RangedSensor< rradius of the sensor originclass BinaryFOVSensor(RangedSensor)RangedSensorfor nearby agentsIn other words,
BinaryFOVSensornow inherits from a new classRangedSensor.This makes it easier to implement the quadtree-optimized agent getter in other sensors.
I am also introducing
RelativeAgentSensor, which returns relative coordinates to nearby agents, from a global frame (i.e. 5 meters East, 2 meters North), as opposed to agent/sensor body frame. This can of course be extended in the future with a config option to return body frame coordinates.This sensor passes all tests in
tests/sensorsat this time, and I have run an SNN milling test which returns the same Circliness up to 4 decimal places (0.9421w/ casPYan,0.9389w/ caspian)This PR also includes some changes to the way that BinaryFOVSensor calculates the FOV axis-aligned bounding box, which I did for readability. I have NOT benchmarked this change for performance uplift/degradation.