feat: add orbiting circles for community section on landing page#88
Closed
techmannih wants to merge 2 commits intokeploy:mainfrom
Closed
feat: add orbiting circles for community section on landing page#88techmannih wants to merge 2 commits intokeploy:mainfrom
techmannih wants to merge 2 commits intokeploy:mainfrom
Conversation
Signed-off-by: techmannih <manishchaudharyttt@gmail.com>
Contributor
|
You just copy pasted exact same changes I did. |
Contributor
Author
|
@khareyash05 please review |
khareyash05
suggested changes
Oct 14, 2024
Signed-off-by: techmannih <manishchaudharyttt@gmail.com>
Contributor
Author
please check once it's totally changed, @khareyash05 also check please |
Member
|
Closing due to unaddressed comments |
Contributor
Author
|
@khareyash05 Which comment did I not reply to? I am working on the issue. You can also check that this is not copied code. |
Sonichigo
reviewed
Oct 15, 2024
components/community.tsx
Outdated
| style={showExtraStyle ? { ...style } : {}} | ||
| className={`${ | ||
| showExtraStyle ? "circle" : "w-3/4 mx-auto mb-5" | ||
| showExtraStyle ? "circle" : "w-[280px] mx-auto mb-5" |
Contributor
There was a problem hiding this comment.
any specific for the 280px ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close keploy/keploy#2159
Issue keploy/keploy#2159
@khareyash05 @Swpn0neel please review PR and merge it.
Now
20241009100015.mp4