Merged
Conversation
Contributor
Author
|
🧪 Testing To try out this version of the SDK, run: Expires at: Fri, 16 Jan 2026 23:31:59 GMT |
| ) -> ResponseT: | ||
| opts = FinalRequestOptions.construct(method="patch", url=path, json_data=body, **options) | ||
| opts = FinalRequestOptions.construct( | ||
| method="patch", url=path, json_data=body, files=to_httpx_files(files), **options |
There was a problem hiding this comment.
Bug: Async patch method uses sync file handling function
The async patch method incorrectly uses the synchronous to_httpx_files(files) instead of await async_to_httpx_files(files). The async post method (line 1763) and async put method (line 1791) both correctly use await async_to_httpx_files(files). When files contain PathLike objects, the sync version will perform blocking I/O (path.read_bytes()) in an async context, potentially blocking the event loop.
c899551 to
eae0512
Compare
eae0512 to
0824aba
Compare
0824aba to
1570b63
Compare
1570b63 to
1ff2d12
Compare
1ff2d12 to
601a341
Compare
Sayan-
approved these changes
Dec 17, 2025
Contributor
Author
|
🤖 Release is at https://github.com/onkernel/kernel-python-sdk/releases/tag/v0.24.0 🌻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Release PR
0.24.0 (2025-12-17)
Full Changelog: v0.23.0...v0.24.0
Features
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
Note
Adds Credentials CRUD API and extends agent auth (delete/reauth, credential linking, enhanced invocation response), updates browser pool types, and adds files support to PATCH methods.
client.credentialsresource withcreate/retrieve/update/list/delete; addsCredentialand related param types.delete /agents/auth/{id}andpost /agents/auth/{id}/reauth(returnsReauthResponse).credential_name.createacceptssave_credential_asand returns a discriminated union (already_authenticated|invocation_created).BrowserPoolRequestwithBrowserPoolConfiginBrowserPool.filessupport topatch()(sync/async) in_base_client.cached_property; addcredentialsresource; update raw/streaming wrappers.api.mdand tests for new endpoints and types; configured endpoints:82 → 89.0.24.0and update changelog.Written by Cursor Bugbot for commit 601a341. This will update automatically on new commits. Configure here.