-
Notifications
You must be signed in to change notification settings - Fork 14
Add WiFi Access point support #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a73ecce to
b5cb686
Compare
* Add support for AP (list connected stations) * Add scan-mode (Scan without create a fully configured station) Signed-off-by: Mattias Walström <lazzer@gmail.com>
47a14d7 to
aeabb3e
Compare
* Wi-Fi station still work (changed YANG model) * Wi-Fi access point supported Model is flexible to support even more modes
Example usage: ./src/statd/python/yanger/yanger -p wifi0 -x "ixll -A ssh enp195s0f0 sudo" ietf-hardware | ./board/common/rootfs/usr/libexec/infix/wifi-channel-map.py Show the congestion in the 2.4 band. Signed-off-by: Mattias Walström <lazzer@gmail.com>
This allows to run yanger remote. Signed-off-by: Mattias Walström <lazzer@gmail.com>
|
Future improvements (not included in this PR):
|
troglobit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments and suggestions.
Also, please run Coverity Scan on this branch. There's a lot of C changes and additions ...
| @@ -0,0 +1,4 @@ | |||
| # Rename WiFi PHY devices from phy0 to wifi-phy0 to avoid name clashes | |||
| # This must run before wlan interface cleanup (70-rename-wifi.rules) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusing comment, 70-rename-wifi.rules is removed in this PR.
| /* Note: WiFi radio handling is now integrated into hardware_change() */ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lingering comment?
| /* Note: WiFi radio handling is now integrated into hardware.c/hardware_change() */ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here? I don't think this helps, just adds to the confusion. I mean, we didn't have radio handling before?
|
|
||
| revision 2025-11-28 { | ||
| description | ||
| "Add support for 00 - World regularity domain."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/regularity/regulatory/ I supposed?
| service <!> name:hostapd :%i \ | ||
| [2345] hostapd -P/var/run/hostapd-%i.pid /etc/hostapd-%i.conf \ | ||
| -- Wi-Fi Access Point @%i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, one tab indent for each continuation row is sufficient.
| ------------------------- | ||
|
|
||
| > [!WARNING] | ||
| > **BREAKING CHANGES:** This release includes breaking changes to WiFi configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly think we should have a migrate script that detects and disables any wifi config so users don't end up with a broken config.
| "name": "radio0", | ||
| "class": "infix-hardware:wifi", | ||
| "infix-hardware:wifi-radio": { | ||
| "country-code": "DE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DE?
| "name": "radio1", | ||
| "class": "infix-hardware:wifi", | ||
| "infix-hardware:wifi-radio": { | ||
| "country-code": "DE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same ETSI domain as SE for Wi-Fi, and conservative enough to be legal across most of EU, I guess?
This fix #1082 by adding a scan mode which is a wifi interface with only a radio in the wifi container.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: