Misc wifi fixes #1343
Merged
Misc wifi fixes #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
requested changes
Jan 6, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Nice work, clean no fuss. Only one comment, in addition to the change request: last commit -> s/is not allowed/are not allowed/
This to be able to use the function in hardware.c, when setting up bssids.
If an interface is name is wifiN-whatever it will be infered with the wifi type. Natural naming whould be wifi0-ssid.
use sh -c to expand the *
This since hostapd change MAC address from its insane logic radio + 1, if bssid is not set.
This is described on the internet as: "If you are unlucky and have a device with wrong MAC address, too bad" For us: We set mac addresses static, and do not use hostapds, insane MAC address allocation (radio MAC + n).
Did not work in some cases.
mattiaswal
force-pushed
the
misc-wifi-fixes
branch
from
b586798 to
f195a0a
Compare
troglobit
approved these changes
Jan 6, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Nice work, it's the small things that really do it! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: