Skip to content

test: bridge_vlan_separation: Make test more robust #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattiaswal merged 1 commit into from
Nov 28, 2024
Merged

test: bridge_vlan_separation: Make test more robust #842

mattiaswal merged 1 commit into from
Nov 28, 2024

Conversation

@mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Nov 28, 2024 •
edited
Loading

Only check for the broadcast sent.

And add more test specification steps

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal
test: bridge_vlan_separation: Make test more robust
b36e55e 
Only check for the broadcast sent.

And add more test specification steps
@mattiaswal mattiaswal requested review from axkar and wkz and removed request for wkz November 28, 2024 09:34
axkar
axkar approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@axkar axkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattiaswal mattiaswal merged commit f6bd209 into main Nov 28, 2024
6 checks passed
@mattiaswal mattiaswal deleted the update-vlan-separation-test branch November 28, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axkar axkar axkar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattiaswal @axkar