Open
Conversation
Implemented Alpha CLIP
Collaborator
|
Thanks for the PR! Based on my understanding, it seems that the code changes include 1) nerfstudio link/url changes, 2) additional annotations on original LERF, and 3) alpha-code changes. Would it be possible to decouple the changes associated with (3) to a different PR so we can review it separately? (1) and (2) should be good to merge. FYI, the changes seems related to #63? |
|
Hey! I also noticed that now the main branch is not compactile with nerf 0.3.X version, is it possible to update the requirement of nerfstudio in pyproject.toml as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trivial change, hoping it helps others getting started on LERF