You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
German version:
Moin,
ich habe die Oberfläche moderner gestaltet inklusive eines dunklen Modus'. Die Oberfläche übernimmt standardmäßig das gewählte Thema des Systems (hell o. dunkel). Der Nutzer kann das Thema in den Einstellungen aber auch unabhängig vom Systemthema ändern. Außerdem habe ich das Erstellen neuer Workspaces rein über Tastaturbefehle ermöglicht.
English version:
Hi,
I did a design overhaul and integrated a dark theme. The interface takes over the system's current theme (light or dark) by default. Though the user can change the theme in conex' settings seperate from the system's one. Besides I made the creation of new workspaces possible purely with keyboard commands.
Hey (sticking to english so more people can follow if they wish so): thanks a lot for this pull request!
I like the look much better, a very good improvement. However: Testing the extension I figured that it doesn't work anymore -- only did a really short test though.
Interestingly enough, I am currently in the process of rewriting the extension. I did a full rewrite using web-components 1 1/2 years ago but the performance was not holding up. I am very confident, that the current rewrite will perform well. I am kind of sorry, that you had to dig through the old code as it was really hard to maintain.
So, what do you think: it'd be possible to get your PR in and release the current version ... need to look what breaks -- did it work ok for you? Alternatively, you could rather spend the time on the new version (need to push it to github).
The HTML-structure changed quite a bit and the current css uses CSS-Grid which I think is much easier to handle.
The future will be the new version though, as I am developing with automated testing to make the code more maintainable.
Hi again,
I'm very pleased to hear that you like it.
The rewrite sounds great, I could have asked about it before doing my stuff, but due to the last commit happening 1 1/2 years ago I assumed this project to rest.
Too bad that I apparently broke the extension, which surprises me, because it works great for me. What in particular didn't work out for you?
Counterquestion regarding your other question: How far is it to the first release candidate of your rewrite? If it's still a while to go, I would indeed love to see my changes in the current version (given that it works reliable, of course), but I understand that it's wasted time in view of an imminent new version. So if you'd push the new version to github, I'd try to transfer my changes.
Best regards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
German version:
Moin,
ich habe die Oberfläche moderner gestaltet inklusive eines dunklen Modus'. Die Oberfläche übernimmt standardmäßig das gewählte Thema des Systems (hell o. dunkel). Der Nutzer kann das Thema in den Einstellungen aber auch unabhängig vom Systemthema ändern. Außerdem habe ich das Erstellen neuer Workspaces rein über Tastaturbefehle ermöglicht.
English version:
Hi,
I did a design overhaul and integrated a dark theme. The interface takes over the system's current theme (light or dark) by default. Though the user can change the theme in conex' settings seperate from the system's one. Besides I made the creation of new workspaces possible purely with keyboard commands.