Open
Conversation
- Import platform module for OS detection - Create getShellCommand() helper for platform-specific shell selection - Use cmd.exe on Windows, /bin/bash on Unix - Update BashSession.initialize() and executeBashCommand() - Maintains backwards compatibility with Unix systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The cipher bash tool had hardcoded
/bin/bashpaths that don't exist on Windows, causing ENOENT (Error: No Entry) failures when running as MCP server on Windows.Root Cause
The bash tool was using Unix-specific absolute paths without checking the operating system. Windows has
cmd.exeandpowershell.exe, but no/bin/bashdirectory.Solution
Added OS detection using the
platformmodule to select the appropriate shell:cmd.exewith args['/c']/bin/bashwith args['-c']Changes Made
Modified:
src/core/brain/tools/definitions/system/bash.tsplatformfrom theosmodulegetShellCommand()helper function that returns:{ shell: 'cmd.exe', args: ['/c'] }{ shell: '/bin/bash', args: ['-c'] }BashSession.initialize()- Uses platform-appropriate shellexecuteBashCommand()- Uses platform-appropriate shellTesting
Scope
This is a minimal, surgical fix that: