Skip to content

Fix credential exposure in keygen() tracebacks #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bubblegum-h wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix credential exposure in keygen() tracebacks #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions lib/pan/xapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,22 +603,26 @@ def keygen(self, extra_qs=None):
if extra_qs is not None:
query = self.__merge_extra_qs(query, extra_qs)

response = self.__api_request(query)
if not response:
raise PanXapiError(self.status_detail)
try:
response = self.__api_request(query)
if not response:
raise PanXapiError(self.status_detail)

if not self.__set_response(response):
raise PanXapiError(self.status_detail)
if not self.__set_response(response):
raise PanXapiError(self.status_detail)

if self.element_result is None:
raise PanXapiError('keygen(): result element not found')
element = self.element_result.find('key')
if element is None:
raise PanXapiError('keygen(): key element not found')
if self.element_result is None:
raise PanXapiError('keygen(): result element not found')
element = self.element_result.find('key')
if element is None:
raise PanXapiError('keygen(): key element not found')

self.api_key = element.text
self.api_key = element.text

return self.api_key
return self.api_key
finally:
if isinstance(query, dict) and 'password' in query:
del query['password']

@staticmethod
def __qs_to_dict(qs):
Expand Down