WIP: wiring the vector manager up in synchronize#376
Open
friendlymatthew wants to merge 1 commit intomainfrom
Open
WIP: wiring the vector manager up in synchronize#376friendlymatthew wants to merge 1 commit intomainfrom
friendlymatthew wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work in progress. This PR adds the wiring logic for
FieldTypeVector.What's been done
Base case:
The
JSONLHandlerwill create aVectorPageManagerupon first entry. Need to serialize the entry node.Rest:
Given the correct
BTreeandBPTreepages, theVectorPageManagerupdates thehnsw, then writes information about the freshly inserted vector.Todo
Currently a linked meta page is unique if it has a different
FieldNameandFieldType. However with a new storage data structureBTree, we also need to factor inTreeTypeas well.FindOrCreateIndex()needs to return a list of unique pages. In the vector case, it should return two pages, theIdtoPointmappingBTreeand theFriendsmappingBPTree.hnsw.Hnswwill be stateful and it'll only be correct whenhandleJsonObjectgets called last.Additional thoughts: