Build scripts #23
Open
Build scripts #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanny17
requested changes
Feb 26, 2017
Owner
khanny17
left a comment
khanny17
left a comment
There was a problem hiding this comment.
The config things were correct already. Also, what's with the XML files? in the .idea folder?
config/passport.js
Outdated
| // load up the user model | ||
| var User = require('../app/models/user'); | ||
| var config = require('../config/config'); // get db config file | ||
| var config = require('../config/config.dev.js'); // get db config file |
Owner
There was a problem hiding this comment.
So this isn't correct. In our source files we have config.dev.js. Gulp renames this to config.js. The reason for this is we will have multiple config files - for example, we might have config.prod.js. By specifying the environment when running gulp, it will automagically select the right configuration for what we want to use
added 2 commits
March 2, 2017 18:36
temp remove sourcemapping
khanny17
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fixes and documentation to the build process.
Should be easier for others to contribute.