Skip to content

Nre/df fixes#130

Merged
a-sr merged 6 commits intomasterfrom
nre/df-fixes
Oct 7, 2025
Merged

Nre/df fixes#130
a-sr merged 6 commits intomasterfrom
nre/df-fixes

Conversation

@NiklasRentzCAU
Copy link
Member

Fixes a number of bugs related to different options in the SCCharts dataflow synthesis. See the individual commits for details.

Accidentally also includes the fix for PR #128, I can rebase this PR if necessary to exclude that here.

@NiklasRentzCAU
Copy link
Member Author

Fixes #27, Fixes #33. The fix for #33 may need to be reviewed and tested with graphs with actions in DF regions, as this possibly affects more than just the declarations in DF regions. I could not find any behavior that is different from the current main branch, though.

@a-sr
Copy link
Member

a-sr commented Oct 6, 2025

I merged the current master and resolved conflicts. Please check if the fixes on this branch are still effective.

@NiklasRentzCAU
Copy link
Member Author

All fixes included in this PR still function as intended by the fix.

Copy link
Member

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@a-sr a-sr merged commit 5f02d12 into master Oct 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants