-
Notifications
You must be signed in to change notification settings - Fork 48
feat: document connectionId parameter for the iOS SDK #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded documentation to the iOS SDK guide describing passing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Deploying kinde-docs-preview with
|
| Latest commit: |
0c6ac3d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b5dbbdba.kinde-docs-preview.pages.dev |
| Branch Preview URL: | https://feat-ios-sdk-connection-id-p.kinde-docs-preview.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/content/docs/developer-tools/sdks/native/ios-sdk.mdx (1)
268-274: Consider showingCONNECTION_IDas a string literal for clarity.While using a constant name like
CONNECTION_IDis valid Swift, showing it as a string literal in the example would help developers immediately understand the expected value format. This is especially helpful since the second code block (lines 282-292) shows concrete examples forloginHint.🔎 Suggested improvement
```swift -KindeSDKAPI.auth.login(connectionId: CONNECTION_ID) +KindeSDKAPI.auth.login(connectionId: "conn_123456789") -KindeSDKAPI.auth.register(connectionId: CONNECTION_ID) +KindeSDKAPI.auth.register(connectionId: "conn_123456789") -KindeSDKAPI.auth.createOrg(connectionId: CONNECTION_ID) +KindeSDKAPI.auth.createOrg(connectionId: "conn_123456789")And add a note before line 268: ```markdown Replace `conn_123456789` with your specific connection identifier from the Kinde dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/content/docs/developer-tools/sdks/native/ios-sdk.mdx (2)
671-682: Consider adding usage examples for the new parameters.The parameter list correctly includes
loginHintandconnectionId, but the usage examples only demonstrate basic usage andorgCode. While these parameters are shown in the earlier "Use custom auth pages" section (lines 269-273, 283-292), adding a brief example here would improve consistency and make the API reference more self-contained.Example usage to add
// With connectionId KindeSDKAPI.auth.login(connectionId: "conn_123") // With loginHint and connectionId KindeSDKAPI.auth.login(loginHint: "user@example.com", connectionId: "conn_123")
703-706: Consider adding usage examples for the new parameters.Similar to the
loginmethod, theregisterusage examples could benefit from demonstrating the newly documented parameters (loginHint,connectionId,planInterest,pricingTableKey) to maintain consistency with the parameter list and improve the API reference completeness.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/developer-tools/sdks/native/ios-sdk.mdx
🔇 Additional comments (3)
src/content/docs/developer-tools/sdks/native/ios-sdk.mdx (3)
263-277: LGTM! Clear documentation of connectionId parameter.The section clearly documents the
connectionIdparameter usage with appropriate Swift examples and links to relevant documentation for obtaining the connection ID.
278-297: LGTM! Helpful examples with multiple formats.The subsection effectively demonstrates the
loginHintparameter with both email and phone number formats, and appropriately links to related documentation for context.
753-754: LGTM! Parameter correctly documented.The
connectionIdparameter is appropriately added as an optional parameter. The usage example at line 273 in the earlier section demonstrates how to use it, so the API reference is consistent.
Description (required)
This PR document the
connectionIdparameter and its usage in the Kinde iOS SDK.Related issues & labels (optional)
connectionIdparameter kinde-sdk-ios#38Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.